Skip to content

IBX-5705: Fixed handler as getTokenType returns object not id #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alongosz merged 1 commit into from
Sep 19, 2023
Merged

IBX-5705: Fixed handler as getTokenType returns object not id #267

alongosz merged 1 commit into from
Sep 19, 2023

Conversation

@Nattfarinn
Copy link
Contributor

@Nattfarinn Nattfarinn commented Aug 28, 2023

Question Answer
JIRA issue IBX-5705
Type bug
Target Ibexa version v4.6
BC breaks no

Checklist:

  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@Nattfarinn Nattfarinn requested a review from a team August 28, 2023 12:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team August 28, 2023 12:19
@alongosz alongosz merged commit f020797 into main Sep 19, 2023
@alongosz alongosz deleted the fix-token-handler branch September 19, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

+1 more reviewer

@webhdx webhdx webhdx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

Labels

Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Nattfarinn @alongosz @webhdx @konradoboza @kisztof @mikadamczyk