IBX-8138: [Rector] Applied rules from Symfony 5 Rector set lists #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Jul 22, 2024
Steveb-p
approved these changes
Jul 22, 2024
Contributor
Steveb-p
left a comment
Steveb-p
left a comment
There was a problem hiding this comment.
A lot of times here types could be narrowed (string instead of string|array, for example) but as this process was automatic and this would require effort for little value, I'll be okay to not address that.
adamwojs
approved these changes
Jul 22, 2024
Applied rules: * AddReturnTypeDeclarationRector
alongosz
force-pushed
the
ibx-8138-symfony-5-rule-sets
branch
from
7e0a5ab to
2c61299
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Applied rules from Symfony 5 Rector set lists.
For QA:
No QA needed. Regression tests should be enough.
Documentation:
This is code refactoring without behavior change. No documentation changes needed.