Skip to content

Renamed domain names #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikadamczyk merged 6 commits into from
Sep 5, 2023
Merged

Renamed domain names #886

mikadamczyk merged 6 commits into from
Sep 5, 2023

Conversation

@mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Aug 25, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6415
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mikadamczyk mikadamczyk self-assigned this Aug 25, 2023
@adamwojs
Copy link
Member

adamwojs commented Aug 25, 2023

Code style is broken in JS files for some reason:

$ yarn prettier "./src/bundle/Resources/**/*.{js,scss}" "./src/bundle/ui-dev/**/*.js" --check
$ /home/runner/work/admin-ui/admin-ui/node_modules/.bin/prettier './src/bundle/Resources/**/*.{js,scss}' './src/bundle/ui-dev/**/*.js' --check
Checking formatting...
[warn] src/bundle/ui-dev/src/modules/universal-discovery/components/content-create-widget/content.create.widget.js

@mikadamczyk mikadamczyk force-pushed the renamed-domain-names branch from 5725b91 to 97c4c06 Compare August 29, 2023 14:02
@tischsoic tischsoic force-pushed the fix-translations branch 2 times, most recently from dcc53e7 to 15eae92 Compare August 30, 2023 13:28
@mikadamczyk mikadamczyk changed the base branch from fix-translations to main September 1, 2023 11:35
@mikadamczyk mikadamczyk requested review from a team, konradoboza and tischsoic September 5, 2023 08:58
konradoboza
konradoboza requested changes Sep 5, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
6.8% 6.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mikadamczyk mikadamczyk merged commit f3fe165 into main Sep 5, 2023
@mikadamczyk mikadamczyk deleted the renamed-domain-names branch September 5, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mikadamczyk @adamwojs @konradoboza @Nattfarinn @ciastektk @dew326 @ViniTou