Skip to content

IBX-6252: Update hover styles for --selector button #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dew326 merged 2 commits into from
Sep 13, 2023
Merged

IBX-6252: Update hover styles for --selector button #877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02ab0ba
IBX-6252: Update hover styles
GrabowskiM Aug 22, 2023
76c9b6b
remove hover from disabled
GrabowskiM Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/bundle/Resources/public/scss/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@
color: $ibexa-color-dark;
fill: $ibexa-color-dark;
padding: calculateRem(11px) calculateRem(12px);
pointer-events: auto;
Copy link
Contributor

@Gengar-i Gengar-i Aug 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property pointer-events: auto is default value.
Shouldn't we delete all of the pointer-events: none values instead?

Copy link
Contributor Author

@GrabowskiM GrabowskiM Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would do such change in new PR/issue, as removing pointer-events: none from all buttons (what you propose if I understand correctly) touches all system, I'd rather not do such big change in this feature PR.
What other thinks? @dew326 @lucasOsti @tischsoic


&.ibexa-btn--selected {
background-color: $ibexa-color-info-200;
Expand All @@ -326,15 +327,30 @@
}

&:not(.ibexa-btn--selected) {
&:hover,
&:focus {
border-color: $ibexa-color-info;
box-shadow: 0 0 0 calculateRem(4px) rgba($ibexa-color-info, 0.2);
}
}

&:focus {
box-shadow: $ibexa-btn-focus-box-shadow-info;
}

&.disabled,
&[disabled],
&:disabled {
color: $ibexa-color-dark-300;
fill: $ibexa-color-dark-300;
border-color: transparent;
box-shadow: none;

&:hover {
.ibexa-icon {
fill: $ibexa-color-dark-300;
}
}
}
}

&--small {
Expand Down