IBX-6315: Edit embedded items #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
1f34c0a to
da8746b
Compare
2 tasks
adamwojs
changed the title
adamwojs
changed the title
tischsoic
force-pushed
the
simplify-action-in-edit-mode
branch
from
0ada79a to
16ecc1b
Compare
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
60c8e10 to
8e31e17
Compare
OstafinL
changed the base branch from
simplify-action-in-edit-mode
to
IBX-6315-edit-preview-embedded-items-TEMP
OstafinL
changed the base branch from
IBX-6315-edit-preview-embedded-items-TEMP
to
simplify-action-in-edit-mode
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
4 times, most recently
from
b9311f3 to
2dc6e9e
Compare
tischsoic
force-pushed
the
simplify-action-in-edit-mode
branch
from
76aea15 to
5ffc829
Compare
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
2 times, most recently
from
ac49197 to
47120ac
Compare
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
b888211 to
20dace6
Compare
Contributor
|
As discussed, please add search and scroll to language list in "Edit" pop-up menu. 🙂 |
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
2 times, most recently
from
2e1c050 to
ab7e6f2
Compare
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
ab7e6f2 to
936dec1
Compare
GrabowskiM
requested changes
Oct 17, 2023
src/bundle/Resources/public/js/scripts/core/multilevel.popup.menu.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/core/multilevel.popup.menu.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/embedded.item.actions.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/embedded.item.actions.js
Outdated
Show resolved
Hide resolved
tischsoic
reviewed
Oct 17, 2023
...views/themes/admin/ui/component/multilevel_popup_menu/multilevel_popup_menu_branch.html.twig
Outdated
Show resolved
Hide resolved
...s/views/themes/admin/ui/component/multilevel_popup_menu/multilevel_popup_menu_item.html.twig
Outdated
Show resolved
Hide resolved
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
760ea35 to
b5bf49e
Compare
tischsoic
approved these changes
Oct 17, 2023
OstafinL
force-pushed
the
IBX-6315-ux-edit-embeded-items
branch
from
b5bf49e to
a9107bb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
approved these changes
Oct 17, 2023
dew326
approved these changes
Oct 17, 2023
micszo
approved these changes
Oct 19, 2023
Contributor
micszo
left a comment
micszo
left a comment
There was a problem hiding this comment.
Found issues (relations multiple, scroll&search) have been addressed.
Targeting block to be handled separately.
QA Approved on Ibexa Commerce 4.6.x-dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realated PRs:
Frontend PR's:
Backend PR's:
Checklist:
$ composer fix-cs)