Skip to content

IBX-7448: Fixed wrong used of name instead of identifier for siteaccess form dropdown value #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViniTou merged 1 commit into from
Feb 2, 2024
Merged

IBX-7448: Fixed wrong used of name instead of identifier for siteaccess form dropdown value #1147

ViniTou merged 1 commit into from
Feb 2, 2024

Conversation

@ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Feb 2, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7448
Type bug
Target version v4.6
BC breaks no
Doc needed no

As in first place this was build upon bug in twig form, I made that same mistake as there 😅

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@ViniTou ViniTou requested a review from a team February 2, 2024 07:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk requested a review from a team February 2, 2024 08:25
@katarzynazawada katarzynazawada mentioned this pull request Feb 2, 2024
Closed
@ViniTou ViniTou merged commit 007ce6b into main Feb 2, 2024
@ViniTou ViniTou deleted the ibx-7448-fixed-regression branch February 2, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

+1 more reviewer

@webhdx webhdx webhdx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels

QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ViniTou @mikadamczyk @webhdx @konradoboza @katarzynazawada @Nattfarinn @ciastektk