Skip to content

IBX-7675: Added showImageFilters parameter to DamWidget config provider #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ciastektk merged 4 commits into from
Feb 5, 2024
Merged

IBX-7675: Added showImageFilters parameter to DamWidget config provider #1144

ciastektk merged 4 commits into from
Feb 5, 2024

Conversation

@ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Jan 31, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7675
Type bug
Target version v4.6
BC breaks no
Doc needed no

Image filtering is not supported in LSE and this causes error after using one of image filter.
This is backend part of fix by providing dedicated parameter to manipulate visibility of image filters. Value is taken from current used repository search engine.

Image Picker PR:

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@ciastektk ciastektk changed the title IBX-7675: Fixed image filtering for lse IBX-7675: Fixed image filtering for LSE Jan 31, 2024
@ciastektk ciastektk requested a review from a team January 31, 2024 13:05
@ciastektk ciastektk added Bug Something isn't working Ready for review labels Jan 31, 2024
@ciastektk ciastektk changed the title IBX-7675: Fixed image filtering for LSE IBX-7675: Added showImageFilters parameter to DamWidget config provider Jan 31, 2024
ViniTou
ViniTou reviewed Jan 31, 2024
View reviewed changes
@ciastektk ciastektk requested review from a team and ViniTou January 31, 2024 14:50
konradoboza
konradoboza approved these changes Feb 1, 2024
View reviewed changes
@konradoboza konradoboza requested a review from a team February 1, 2024 12:51
tomaszszopinski
tomaszszopinski approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

Base automatically changed from renamed-image-picker-config-provider to main February 5, 2024 13:04
@ciastektk ciastektk force-pushed the ibx-7675-fixed-image-filtering-for-lse branch from 4e631f1 to 263504a Compare February 5, 2024 13:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ciastektk ciastektk merged commit a1eadd2 into main Feb 5, 2024
@ciastektk ciastektk deleted the ibx-7675-fixed-image-filtering-for-lse branch February 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

+1 more reviewer

@webhdx webhdx webhdx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels

Bug Something isn't working QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ciastektk @webhdx @ViniTou @konradoboza @tomaszszopinski @mikadamczyk @Nattfarinn