IBX-7050: Frontend: top bar and change site switcher #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-7050-topbar
branch
from
2d960f6 to
912071a
Compare
tischsoic
reviewed
Dec 18, 2023
| <div class="ibexa-user-mode-badge"> | ||
| {{ 'user_mode_badge.focus'|trans|desc('Focus mode') }} | ||
| </div> | ||
| {% endif %} No newline at end of file |
| @@ -0,0 +1,7 @@ | |||
| {% trans_default_domain 'ibexa_user_mode_badge' %} | |||
|
|
|||
| {% if ibexa_is_focus_mode_on() == true %} | |||
Contributor
There was a problem hiding this comment.
This should also work?
Suggested change
| {% if ibexa_is_focus_mode_on() == true %} | |
| {% if ibexa_is_focus_mode_on() %} |
|
|
||
| &:focus { | ||
| border-color: $ibexa-color-white; | ||
| box-shadow: 0px 0px 0px calculateRem(4px) rgba($ibexa-color-white, 0.2); |
Contributor
There was a problem hiding this comment.
nitpick
Suggested change
| box-shadow: 0px 0px 0px calculateRem(4px) rgba($ibexa-color-white, 0.2); | |
| box-shadow: 0 0 0 calculateRem(4px) rgba($ibexa-color-white, 0.2); |
dew326
approved these changes
Dec 19, 2023
Gengar-i
approved these changes
Dec 21, 2023
|
tomaszszopinski
approved these changes
Jan 8, 2024
Contributor
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
QA approved on IbexaDXP 4.6 commerce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing content tree part, as there's totally different problem with content tree...
with https://github.com/ibexa/site-context/pull/20
Checklist:
$ composer fix-cs)