IBX-7302: No left sidebar when no anchor menu items #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Dec 8, 2023
Gengar-i
approved these changes
Dec 8, 2023
GrabowskiM
approved these changes
Dec 8, 2023
dew326
approved these changes
Dec 11, 2023
Gengar-i
approved these changes
Dec 11, 2023
GrabowskiM
approved these changes
Dec 12, 2023
tischsoic
force-pushed
the
IBX-7302-remove-left-sidebar-when-no-anchor-items
branch
from
6f896ce to
a03ef0a
Compare
katarzynazawada
requested changes
Dec 15, 2023
Contributor
katarzynazawada
left a comment
katarzynazawada
left a comment
There was a problem hiding this comment.
- Sidebar is still visible in language form
-
Line in the form changes length https://recordit.co/AkbzpiUdBW
-
Meta tab is not displayed in the form
Contributor
Author
|
@katarzynazawada, reported problems should be fixed now except for 2nd which is not related to this PR (this bug also occurs on the main/Nightly). I also added additional PRs: |
dew326
approved these changes
Dec 20, 2023
Gengar-i
suggested changes
Dec 21, 2023
Gengar-i
approved these changes
Dec 21, 2023
GrabowskiM
approved these changes
Jan 2, 2024
|
katarzynazawada
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Checklist:
$ composer fix-cs)