-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: allow mixed precision policy as dtype #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
Signed-off-by: Mehant Kammakomati <[email protected]>
|
@S1ro1 WDYT on this? |
|
Hey @kmehant currently OOO, will give it a look next week! |
|
Sure, @S1ro1 thanks! |
S1ro1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we maybe add tests? (should be simple enough to just adapt the current ones for MP to also test this)
SunMarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just add a test if possible
Signed-off-by: Mehant Kammakomati <[email protected]>
S1ro1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |

What does this PR do?
Allow mixed precision to be passed as a dtype string from accelerate cli flag or
fsdp_configin accelerate config file.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@S1ro1 @SunMarc