Skip to content

Conversation

@jayohms
Copy link
Collaborator

@jayohms jayohms commented Nov 17, 2023

This PR:

  • Updates the compile/target SDK to 34
  • Upgrades the build tools to be compatible with SDK 34
  • Bumps many androidx.* dependencies, which have some new features available

@jayohms jayohms requested a review from mbarta November 17, 2023 05:24
Copy link
Contributor

@mbarta mbarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks!

@jayohms jayohms merged commit 1f1f7b6 into main Nov 17, 2023
@jayohms jayohms deleted the bump-dependencies branch November 17, 2023 14:31
@sedubois
Copy link

@jayohms could you say what the minSdkVersion bump from 24 to 26 is required for? This drops support for Android 7, which is a breaking change.

@jayohms
Copy link
Collaborator Author

jayohms commented Nov 20, 2023

@sedubois Google is ending support for Chrome on Android 7 (and the system WebView), so this change corresponds to Google's decision. Android 7 was released in 2016 and the library hasn't bumped it's required minSdkVersion in 3 years, so it's long overdue.

https://www.androidpolice.com/chrome-120-ending-support-for-android-nougat/

kyrylo added a commit to kyrylo/turbo-android that referenced this pull request Jan 2, 2024
kyrylo added a commit to kyrylo/turbo-android that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants