fix(d/query_specification): Allow wider granularity range #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalboni
changed the title
jharley
reviewed
Sep 22, 2025
Contributor
jharley
left a comment
jharley
left a comment
There was a problem hiding this comment.
Looks good! Two quick things ahead of approval:
- the docs need to be updated as well as they're not autogenerated.
docs/data-sources/query_specification.md(link) - (minor) the PR title should be
fix(d/query_specification): [...]as it's a data source not a resource
jbalboni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
This updates the granularity validation logic to match the API, where we allow granularities that create as few as 1 bucket in the query results, instead of 10.
How to verify that this has the expected result
Tests pass, I think.