feat(r/query_annotation): add import support #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoodan93
changed the title
jharley
suggested changes
Sep 15, 2025
Contributor
jharley
left a comment
jharley
left a comment
There was a problem hiding this comment.
Thanks for this! Nice work
A few things ahead of a stamp:
- the documentation for the
query_annotationresource needs to be updated to show that it does now support imports - the title of the PR isn't quite right: the prefix should be
feat(r/query_annotation):(as it's affecting thequery_annotationresource. The description itself should likely be a bit more consumer focused (i.e. "add import support") - you should add the 'feature' label to this PR as it is used to generate the changelog for releases
yoodan93
changed the title
Contributor
Author
|
Thank you @jharley , let me get those changes for you! |
yoodan93
changed the title
jharley
changed the title
jharley
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
No issue but something i noticed while migrating boards to Terraform.
We were missing query_annotation import.
Short description of the changes
Adding
ImportStateforquery_annotationresource typeHow to verify that this has the expected result
Adding unit test.
The import state follows similar pattern to the
queryresource.