-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix build failure caused by RaspberryMatic project renaming #4324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RaspberryMatic was renamed to OpenCCU in OpenCCU/OpenCCU#3162. This caused change of the name of the directory in the source tarball, causing build failure when the archive wasn't cached.
📝 WalkthroughWalkthroughUpdated the rpi-rf-mod package metadata: switched the source repository URL in the Buildroot makefile to OpenCCU/OpenCCU while keeping the version unchanged; updated the corresponding tarball sha256 in the hash file. No other entries or licenses modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
buildroot-external/package/rpi-rf-mod/rpi-rf-mod.mk (1)
10-10: Update comment URL to reflect new repository.The comment still references the old RaspberryMatic URL pattern. Consider updating it to match the new OpenCCU repository structure.
Apply this diff to update the comment:
-# https://codeload.github.com/jens-maus/RaspberryMatic/tar.gz/COMMIT +# https://codeload.github.com/OpenCCU/OpenCCU/tar.gz/COMMIT
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
buildroot-external/package/rpi-rf-mod/rpi-rf-mod.hash(1 hunks)buildroot-external/package/rpi-rf-mod/rpi-rf-mod.mk(1 hunks)
🔇 Additional comments (3)
buildroot-external/package/rpi-rf-mod/rpi-rf-mod.mk (2)
13-13: Repository URL updated correctly to OpenCCU.The repository references have been properly updated from RaspberryMatic to OpenCCU, aligning with the project rename referenced in OpenCCU/OpenCCU#3162.
Also applies to: 18-18
44-51: Tarball structure matches expected directory and files. Confirmed that buildroot-external/package/rpi-rf-mod/dts/ and all referenced .dts files are present in the tarball.buildroot-external/package/rpi-rf-mod/rpi-rf-mod.hash (1)
2-2: Manual SHA256 verification requiredThe sandbox environment lacks
sha256sum, so the automated check failed. Please verify the SHA256 of the tarball manually in your local environment, for example:curl -sL https://codeload.github.com/OpenCCU/OpenCCU/tar.gz/0ee62f7a87d26e990fb0e03b00befb505a7e44fd \ | shasum -a 256Confirm the output matches
e1ea74165cd850518284dcc8ee394231aa7684169b752be67604838912fb9f23.
RaspberryMatic was renamed to OpenCCU in OpenCCU/OpenCCU#3162. This caused change of the name of the directory in the source tarball, causing build failure when the archive wasn't cached.
Summary by CodeRabbit