Skip to content

Conversation

@sairon
Copy link
Member

@sairon sairon commented Aug 4, 2025

Make rpi-eeprom-update install latest default FW version when rpi-eeprom-update -a is executed.

Summary by CodeRabbit

  • New Features

    • Updated Raspberry Pi 4 and Raspberry Pi 5 bootloader firmware to the latest versions dated 2025-05-08.
  • Chores

    • Updated package version and checksum for the rpi-eeprom firmware.

Make rpi-eeprom-update install latest default FW version when
`rpi-eeprom-update -a` is executed.
@sairon sairon requested a review from agners August 4, 2025 09:30
@sairon sairon added board/raspberrypi Raspberry Pi Boards board/yellow Home Assistant Yellow labels Aug 4, 2025
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coderabbitai
Copy link

coderabbitai bot commented Aug 4, 2025

📝 Walkthrough

Walkthrough

The rpi-eeprom package was updated to a new upstream commit, resulting in changes to the SHA256 hash, the version identifier, and the EEPROM firmware binaries for Raspberry Pi 4 and 5. The installation logic and directory structure remain unchanged, with only the referenced firmware files and version updated.

Changes

Cohort / File(s) Change Summary
rpi-eeprom version and firmware update
buildroot-external/package/rpi-eeprom/rpi-eeprom.mk, buildroot-external/package/rpi-eeprom/rpi-eeprom.hash
Updated rpi-eeprom version and SHA256 hash; replaced firmware binaries for RPI4 and RPI5 to 2025-05-08 versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between a7bef75 and 5326d55.

📒 Files selected for processing (2)
  • buildroot-external/package/rpi-eeprom/rpi-eeprom.hash (1 hunks)
  • buildroot-external/package/rpi-eeprom/rpi-eeprom.mk (2 hunks)
🔇 Additional comments (4)
buildroot-external/package/rpi-eeprom/rpi-eeprom.hash (1)

2-2: SHA256 checksum verified

The SHA256 hash in buildroot-external/package/rpi-eeprom/rpi-eeprom.hash matches the upstream tarball (2349daafacfb7a7abe2cfecf30a49ae837bdf2c6.tar.gz). No changes needed.

buildroot-external/package/rpi-eeprom/rpi-eeprom.mk (3)

7-8: Version bump looks good — no further action.

RPI_EEPROM_VERSION now points to commit 2349daaf…. Nothing else is needed here.


14-18: Manual verification needed: Confirm updated EEPROM & USB firmware binaries

The automated clone attempt failed because the specified “branch” (2349daafacfb7a7abe2cfecf30a49ae837bdf2c6) wasn’t found. Please verify that the commit ID in rpi-eeprom.mk is correct and that the firmware-2711/default/ directory in that commit contains:

  • pieeprom-2025-05-08.bin (new EEPROM image)
  • Any newer vl805-*.bin (USB controller firmware) beyond vl805-000138c0.bin

You can confirm by running:

git clone https://github.com/raspberrypi/rpi-eeprom.git /tmp/rpi-eeprom
cd /tmp/rpi-eeprom
git checkout 2349daafacfb7a7abe2cfecf30a49ae837bdf2c6
ls -1 firmware-2711/default/

If a newer VL805 blob exists alongside the new EEPROM image, update the install lines in rpi-eeprom.mk accordingly to keep the USB firmware in sync.


22-25: Pi 5 bootloader filename/path confirmed
I’ve checked out commit 2349daafacfb7a7abe2cfecf30a49ae837bdf2c6 in the upstream rpi-eeprom repo and verified that firmware-2712/default/pieeprom-2025-05-08.bin is present. No changes are needed here.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rpi-eeprom-latest-default-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit 6207807 into dev Aug 4, 2025
3 checks passed
@sairon sairon deleted the rpi-eeprom-latest-default-image branch August 4, 2025 09:43
@sairon sairon mentioned this pull request Aug 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

board/raspberrypi Raspberry Pi Boards board/yellow Home Assistant Yellow cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants