-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Docker to v28.3.0 #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker to v28.3.0 #4135
Conversation
* buildroot 758ae477cd...9366ce5635 (6): > package/runc: bump version to v1.3.0 > package/containerd: bump version to v2.1.3 > package/docker-cli: bump version to v28.3.0 > package/docker-engine: bump version to v28.3.0 > package/docker-cli: Fix go module version information > package/docker-engine: Fix go module version information
📝 WalkthroughWalkthroughThe subproject commit reference for the Changes
Sequence Diagram(s)No sequence diagram generated as the change is limited to a submodule reference update. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
buildroot(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: linters
| @@ -1 +1 @@ | |||
| Subproject commit 758ae477cdd3dd5f257f97e469809f724b2cf4f5 | |||
| Subproject commit 9366ce5635cf668fe057029f34700007e9de1f84 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Submodule bump is fine, but confirm downstream patches/build still succeed
The pointer jump to 9366ce5635 brings in Docker 28.3.0, containerd 2.1.3 and runc 1.3.0. These introduce changes in seccomp defaults and cgroup-v2 handling that might break custom HAOS patches or images.
Run a quick dry-run patch check to be safe:
🏁 Script executed:
#!/bin/bash
# Verify that all external HAOS patches still apply cleanly on the new Buildroot commit.
set -euo pipefail
# Ensure submodule is checked out
git submodule update --init buildroot
# Adjust the path to your external tree if different
PATCH_DIR="buildroot-external"
# Fail if any patch is rejected
fd -e patch . "$PATCH_DIR" | while read -r patch; do
echo "Checking $patch"
patch --dry-run -p1 -d buildroot < "$patch" > /dev/null || {
echo "Patch rejected: $patch"
exit 1
}
done
echo "All patches apply cleanly."Length of output: 355
Let’s confirm that we’re targeting the correct patch directory and actually have patches to test.
🏁 Script executed:
#!/bin/bash
# List all patch files in the external HAOS patches directory to verify we’re pointing at the right location
set -euo pipefail
git submodule update --init buildroot
echo "Searching for .patch files under buildroot-external/"
fd -e patch . buildroot-external || echo "No .patch files found in buildroot-external/"Length of output: 11901
🏁 Script executed:
#!/bin/bash
# Re-run dry-run patch application to verify all HAOS external patches against the new Buildroot commit
set -euo pipefail
# Ensure buildroot submodule is at 9366ce5635
git submodule update --init buildroot
PATCH_DIR="buildroot-external"
fd -e patch . "$PATCH_DIR" | while read -r patch; do
echo "Checking $patch"
patch --dry-run -p1 -d buildroot < "$patch" > /dev/null || {
echo "Patch rejected: $patch"
exit 1
}
done
echo "All patches apply cleanly."Length of output: 677
Downstream patches need updates – one or more patches failed to apply
During a dry-run of all HAOS external patches against Buildroot at commit 9366ce5635, the very first patch was rejected:
• buildroot-external/board/arm-uefi/generic-aarch64/patches/linux/0001-r8169-add-support-for-RTL8125D.patch
Please review and rebase or adjust your downstream patches to apply cleanly on the new Buildroot.
🤖 Prompt for AI Agents
In the buildroot file at line 1, the downstream patch
buildroot-external/board/arm-uefi/generic-aarch64/patches/linux/0001-r8169-add-support-for-RTL8125D.patch
failed to apply cleanly on the current Buildroot commit 9366ce5635. Review the
patch for conflicts or outdated changes, then rebase or modify it so it applies
cleanly to the updated Buildroot source. Ensure all patches in the series apply
without errors during the dry-run.
Update Docker and related services to latest versions. * buildroot 758ae477cd...9366ce5635 (6): > package/runc: bump version to v1.3.0 > package/containerd: bump version to v2.1.3 > package/docker-cli: bump version to v28.3.0 > package/docker-engine: bump version to v28.3.0 > package/docker-cli: Fix go module version information > package/docker-engine: Fix go module version information (cherry picked from commit bc484f6)
Summary by CodeRabbit