Skip to content

Conversation

@agners
Copy link
Member

@agners agners commented Jul 1, 2025

  • buildroot 758ae477cd...9366ce5635 (6):

    package/runc: bump version to v1.3.0
    package/containerd: bump version to v2.1.3
    package/docker-cli: bump version to v28.3.0
    package/docker-engine: bump version to v28.3.0
    package/docker-cli: Fix go module version information
    package/docker-engine: Fix go module version information

Summary by CodeRabbit

  • Chores
    • Updated the buildroot component to a newer version.

* buildroot 758ae477cd...9366ce5635 (6):
  > package/runc: bump version to v1.3.0
  > package/containerd: bump version to v2.1.3
  > package/docker-cli: bump version to v28.3.0
  > package/docker-engine: bump version to v28.3.0
  > package/docker-cli: Fix go module version information
  > package/docker-engine: Fix go module version information
@coderabbitai
Copy link

coderabbitai bot commented Jul 1, 2025

📝 Walkthrough

Walkthrough

The subproject commit reference for the buildroot directory has been updated to a newer commit. No other files or code changes are included in this update.

Changes

File(s) Change Summary
buildroot (submodule) Updated submodule commit to a new reference

Sequence Diagram(s)

No sequence diagram generated as the change is limited to a submodule reference update.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9803f5f and 40e952d.

📒 Files selected for processing (1)
  • buildroot (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: linters

@@ -1 +1 @@
Subproject commit 758ae477cdd3dd5f257f97e469809f724b2cf4f5
Subproject commit 9366ce5635cf668fe057029f34700007e9de1f84
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Submodule bump is fine, but confirm downstream patches/build still succeed

The pointer jump to 9366ce5635 brings in Docker 28.3.0, containerd 2.1.3 and runc 1.3.0. These introduce changes in seccomp defaults and cgroup-v2 handling that might break custom HAOS patches or images.

Run a quick dry-run patch check to be safe:


🏁 Script executed:

#!/bin/bash
# Verify that all external HAOS patches still apply cleanly on the new Buildroot commit.

set -euo pipefail
# Ensure submodule is checked out
git submodule update --init buildroot

# Adjust the path to your external tree if different
PATCH_DIR="buildroot-external"

# Fail if any patch is rejected
fd -e patch . "$PATCH_DIR" | while read -r patch; do
  echo "Checking $patch"
  patch --dry-run -p1 -d buildroot < "$patch" > /dev/null || {
    echo "Patch rejected: $patch"
    exit 1
  }
done
echo "All patches apply cleanly."

Length of output: 355


Let’s confirm that we’re targeting the correct patch directory and actually have patches to test.


🏁 Script executed:

#!/bin/bash
# List all patch files in the external HAOS patches directory to verify we’re pointing at the right location
set -euo pipefail
git submodule update --init buildroot
echo "Searching for .patch files under buildroot-external/"
fd -e patch . buildroot-external || echo "No .patch files found in buildroot-external/"

Length of output: 11901


🏁 Script executed:

#!/bin/bash
# Re-run dry-run patch application to verify all HAOS external patches against the new Buildroot commit
set -euo pipefail

# Ensure buildroot submodule is at 9366ce5635
git submodule update --init buildroot

PATCH_DIR="buildroot-external"

fd -e patch . "$PATCH_DIR" | while read -r patch; do
  echo "Checking $patch"
  patch --dry-run -p1 -d buildroot < "$patch" > /dev/null || {
    echo "Patch rejected: $patch"
    exit 1
  }
done

echo "All patches apply cleanly."

Length of output: 677


Downstream patches need updates – one or more patches failed to apply

During a dry-run of all HAOS external patches against Buildroot at commit 9366ce5635, the very first patch was rejected:

• buildroot-external/board/arm-uefi/generic-aarch64/patches/linux/0001-r8169-add-support-for-RTL8125D.patch

Please review and rebase or adjust your downstream patches to apply cleanly on the new Buildroot.

🤖 Prompt for AI Agents
In the buildroot file at line 1, the downstream patch
buildroot-external/board/arm-uefi/generic-aarch64/patches/linux/0001-r8169-add-support-for-RTL8125D.patch
failed to apply cleanly on the current Buildroot commit 9366ce5635. Review the
patch for conflicts or outdated changes, then rebase or modify it so it applies
cleanly to the updated Buildroot source. Ensure all patches in the series apply
without errors during the dry-run.

@sairon sairon changed the title Bump buildroot to update Docker package files Update Docker to v28.3.0 Jul 1, 2025
@sairon sairon added the os label Jul 1, 2025
@sairon sairon merged commit bc484f6 into dev Jul 1, 2025
3 checks passed
@sairon sairon deleted the bump-buildroot-for-docker branch July 1, 2025 15:33
sairon pushed a commit that referenced this pull request Jul 3, 2025
Update Docker and related services to latest versions.

* buildroot 758ae477cd...9366ce5635 (6):
  > package/runc: bump version to v1.3.0
  > package/containerd: bump version to v2.1.3
  > package/docker-cli: bump version to v28.3.0
  > package/docker-engine: bump version to v28.3.0
  > package/docker-cli: Fix go module version information
  > package/docker-engine: Fix go module version information

(cherry picked from commit bc484f6)
@sairon sairon mentioned this pull request Jul 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants