Skip to content

Conversation

@sairon
Copy link
Member

@sairon sairon commented Jun 17, 2025

Add driver for Marvell PHYs, such as 88E1543(4L) on an ASRock C3758D4I-4L board. Adding it to x86 config only, as it seems it's not widely used anywhere else.

Fixes #4025

Summary by CodeRabbit

  • New Features
    • Enabled support for Marvell PHY network devices.
  • Style
    • Improved organization of kernel configuration options with clearer comments.

Add driver for Marvell PHYs, such as 88E1543(4L) on an ASRock C3758D4I-4L
board. Adding it to x86 config only, as it seems it's not widely used anywhere
else.

Fixes #4025
@sairon sairon added linux Linux kernel related issue board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) labels Jun 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 17, 2025

📝 Walkthrough

Walkthrough

The kernel configuration file for the generic x86-64 board was updated by adding a comment to clarify pin control support and enabling the Marvell PHY driver as a loadable module. No existing configuration options were removed or changed.

Changes

File(s) Change Summary
buildroot-external/board/pc/generic-x86-64/kernel.config Added comment for pin control support; enabled CONFIG_MARVELL_PHY=m

Assessment against linked issues

Objective Addressed Explanation
Enable Marvell PHY driver to support Marvell 88E1543(4L) NIC detection (#4025)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5e36e68 and 0d5c915.

📒 Files selected for processing (1)
  • buildroot-external/board/pc/generic-x86-64/kernel.config (1 hunks)
🔇 Additional comments (2)
buildroot-external/board/pc/generic-x86-64/kernel.config (2)

166-168: Section header for pin control
Grouping CONFIG_PINCTRL_CANNONLAKE=m under a "Pin control support" comment enhances readability and maintainability.


169-171: ```shell
#!/bin/bash
cfg="buildroot-external/board/pc/generic-x86-64/kernel.config"

echo "=== CONFIG_MODULES setting ==="
grep -E "^CONFIG_MODULES=[ym]" -n "$cfg" || echo "❌ CONFIG_MODULES not set to y or m"

echo "=== MDIO support settings ==="
grep -E "^CONFIG_MDIO(|_.)=(y|m)" -n "$cfg" || echo "❌ No MDIO support found (CONFIG_MDIO, CONFIG_MDIO_BUS, etc.)"


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIAQVp6AFlnKR9IAA50gFEARgANAshaCklKSAAzfD4AD3SANjA6gBZoyAB3NGQHAWZ1Gno5MNgPbEQyxG0KfCxO6zsMRwEyppyABgBWDRhhxlhMUhQMXCnabAZpdCKSqT5KvmSKVN8rAAkATSKSCXhzxAAaezcUTwco/NA+eTwDAMLzYWhQoiQZiKEheZBeeAAaw8uB2mVy6yaAGYABRNAAyAEoKvhsBh6NMhh5YgBlGz4BiYyAAYSJAHZ1ukACJNACSYApkAE+GctC2cFQxVKfDQCXU8EZqFwzlI/UgJGqMNGpS88juTMgtTq6AoDAQNDE2H8CgwoKITuoGowAIEnSijNxHkEY0enoDe1CgbG1neyGcHgw+FCTFY01NkFG/qwSeGfG4Xmod2YiHlO2w3Fo1A8quK0jGcfpfmk+C8UmQSAcCcWy1WACZNtsPLZGJgpR5/N8SG0olDPtr4L5qBaAKo2clcWC4XDcRAcAD0e6I6lg2AEGhTe9gLBIYE6iCQ2qOe/wQKo4gwRDAiFkiBozD33DeF4e4rBsGhGPoxjgFAZAMuUOAEMQZDKHqKZsEcXC8PwwiiOIbZSvITBKFQqjqFoOiQSYUAKu2DYIYQpDkG+URoewXBUG09iOMwzjyIMRHKKRmjaLoYCGFBpgGAI2ALsU+BJmABo0BQGDgnu0qygBDCHshJQMGAVqNE0e7YipqLntMbocAY0S2QYFiQLE4qMShUQOE4Lj8PBdr7NIbg7EwrrwO6b5ehUC4eB0yDlpWeoEOgCRhG0+CQOQnGmeQviBW6HriIyL55RgJaQAAYvAFC/gCaAKKw7CQBi5AxJYVizoFxwtlx3DcFUuCtFFCVKPQKj4FIFoGg+CKQAABtyADyAByJWigA4gA+lYorzdy0Brqt3KxPN80LeSsQANJZAAvMwU38NwhUAm0CB2u0sy8F8GqjOmdKsUcUTSaEiacag3wOOC6ZEFM5ZRHSxFDKgP2aJALKiNMtBValU4Y7gyUUFySjfOcVzKrdhXTXNi0ratiSxDYABqWTkuS63vFdN39TWURLoG+qNvg8Hc6CkQAmQKgNYiDhdT1NL3CkqLPO8nwExcszVV4MqVgIkRIoo3gkFs80peNv6TdlwW5WFBVesg07Ov4yJSAyKpeMpM5YIG5WQBI4LBCWRjmJYsTOyhVthCl3NKDCzhhkVXn6tU3UUHqVSeJrPw8+E8B+QYUDxINkAZaiLo5aF+V3V6XAzQtS1rdTdMM0zrxvKzhzTdJslTApSmUKpwEaRQtBaTpTE/AZ9RGSZ3fmabRBTTZdnZ2JEkwbz8FoHgDG6VW9AI+xaCce5PGefxKIkWowkUYvVE1b0uCrfAtCIKtE6Z9OtCrb+zihJBBhX6stDrAwAAnDkdYOQ6jgPKAIc4gCGC+gYOsOoaByjlByGgIBgCiSrBIHUHIfJVAMByKJcSV80LqDvg/J+70px0FWrBIhQA= -->

<!-- internal state end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=home-assistant/operating-system&utm_content=4105):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@sairon sairon requested a review from agners June 18, 2025 14:38
CONFIG_PINCTRL_CANNONLAKE=m

# Network devices
CONFIG_MARVELL_PHY=m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this are mostly PCIe devices? I'd suggest to add it to buildroot-external/kernel/v6.12.y/device-support-pci.config, we already have CONFIG_BROADCOM_PHY=m there. Just in case someone passthrough a NIC..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it seems that this is a rather odd quad-gigabit PHY, and the MAC is built into the Atom SoC

image

So at least in this case, this is not related to PCIe at all. It could be that Marvell PHYs are required for PCIe Ethernet controllers, but I guess we can move it if that comes up. So fine by me as is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I reached the same conclusion. device-support-pci.config is incorrect, device-support.config too broad.

@sairon sairon merged commit 6f854b6 into dev Jun 20, 2025
3 checks passed
@sairon sairon deleted the x86-add-marvell-phy-driver branch June 20, 2025 08:05
sairon added a commit that referenced this pull request Jun 26, 2025
Add driver for Marvell PHYs, such as 88E1543(4L) on an ASRock C3758D4I-4L
board. Adding it to x86 config only, as it seems it's not widely used anywhere
else.

Fixes #4025

(cherry picked from commit 6f854b6)
@sairon sairon mentioned this pull request Jun 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) cla-signed linux Linux kernel related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marvell 88E1543(4L) not detected

3 participants