-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Marvell 88E1XXX driver for x86-64 #4105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add driver for Marvell PHYs, such as 88E1543(4L) on an ASRock C3758D4I-4L board. Adding it to x86 config only, as it seems it's not widely used anywhere else. Fixes #4025
📝 WalkthroughWalkthroughThe kernel configuration file for the generic x86-64 board was updated by adding a comment to clarify pin control support and enabling the Marvell PHY driver as a loadable module. No existing configuration options were removed or changed. Changes
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
|
| CONFIG_PINCTRL_CANNONLAKE=m | ||
|
|
||
| # Network devices | ||
| CONFIG_MARVELL_PHY=m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this are mostly PCIe devices? I'd suggest to add it to buildroot-external/kernel/v6.12.y/device-support-pci.config, we already have CONFIG_BROADCOM_PHY=m there. Just in case someone passthrough a NIC..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it seems that this is a rather odd quad-gigabit PHY, and the MAC is built into the Atom SoC
So at least in this case, this is not related to PCIe at all. It could be that Marvell PHYs are required for PCIe Ethernet controllers, but I guess we can move it if that comes up. So fine by me as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I reached the same conclusion. device-support-pci.config is incorrect, device-support.config too broad.

Add driver for Marvell PHYs, such as 88E1543(4L) on an ASRock C3758D4I-4L board. Adding it to x86 config only, as it seems it's not widely used anywhere else.
Fixes #4025
Summary by CodeRabbit