Skip to content

Conversation

@rtyley
Copy link
Member

@rtyley rtyley commented Dec 5, 2025

The blocking-operations thread-pool is no longer used anywhere in the facia app, so we don't need to create it anymore (I should have listened to @ioannakok back in 2023!)

Future candidate for deletion...

The BlockingOperations class (introduced with #18359 in 2017) is currently only used in one place - the ParameterStoreService in the admin app (in service of the frontend.gutools.co.uk/config tool, introduced with #18529):

def findParameterBySubstring(substring: String): Future[Seq[String]] =
blockingOperations.executeBlocking {
parameterStore
.getPath("/frontend", isRecursiveSearch = true)
.collect {
case (key, _) if key.contains(substring) => key
}
.toSeq
}

If parameterStore.getPath() was updated to use an async SSM client, and return a Future, we could drop BlockingOperations (note that the method is also used for initialising config, which Play takes without Futures).

def getPath(path: String, isRecursiveSearch: Boolean = false): Map[String, String] = {

@rtyley rtyley marked this pull request as ready for review December 5, 2025 14:04
@rtyley rtyley requested a review from a team as a code owner December 5, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants