Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blocking-operationsthread-pool is no longer used anywhere in thefaciaapp, so we don't need to create it anymore (I should have listened to @ioannakok back in 2023!)Future candidate for deletion...
The
BlockingOperationsclass (introduced with #18359 in 2017) is currently only used in one place - theParameterStoreServicein theadminapp (in service of the frontend.gutools.co.uk/config tool, introduced with #18529):frontend/admin/app/services/ParameterStoreService.scala
Lines 13 to 21 in 217a205
If
parameterStore.getPath()was updated to use an async SSM client, and return aFuture, we could dropBlockingOperations(note that the method is also used for initialising config, which Play takes withoutFutures).frontend/common/app/services/ParameterStore.scala
Line 23 in ad0b97b