-
-
Notifications
You must be signed in to change notification settings - Fork 129
fix(graphile-build-pg): add more numeric casting exceptions #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benjie
merged 12 commits into
graphile:v4
from
wesselvdv:fix/primary-key-to-numeric-exceptions
Sep 29, 2020
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3b1271e
fix(graphile-build-pg): add additional exceptions for casting to numeric
1c659d7
fix(postgraphile-core): omit regrole & regnamespace if server_version…
5cd6853
feat(graphile-build-pg): add all different reg* types as stringlike g…
f971e19
test(postgraphile-core): add missing snapshots
89928e7
test(postgraphile-core): move regrole and regnamespace to pg10 or hig…
a20296f
fix(postgraphile-core): appease linter
ef3050e
fix(postgraphile-core): change operator to one supported from >=9.4
86709d0
test(postgraphile-core): fix wrong sequence reset
wesselvdv a7bd8e5
test(postgraphile-core): updated snapshot
f09cdc1
test(postgraphile-core): adds missing sequence reset and corrects net…
wesselvdv 41bf6f5
test(postgraphile-core): adds missing ids in mutation and query tests…
wesselvdv 4d45543
Merge branch 'v4' into fix/primary-key-to-numeric-exceptions
benjie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
packages/postgraphile-core/__tests__/fixtures/mutations/pg10.types.graphql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| mutation { | ||
| # Must come next to last | ||
| updateTypeById( | ||
| input: { | ||
| id: 12 | ||
| typePatch: { | ||
| regrole: "postgraphile_test_authenticator" | ||
| regnamespace: "pg10" | ||
| } | ||
| } | ||
| ) { | ||
| type { | ||
| ...type | ||
| } | ||
| } | ||
| # Must come last | ||
| createType( | ||
| input: { | ||
| type: { | ||
| regrole: "postgraphile_test_visitor" | ||
| regnamespace: "c" | ||
| } | ||
| } | ||
| ) { | ||
| type { | ||
| ...type | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fragment type on Type { | ||
| regrole | ||
| regnamespace | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
packages/postgraphile-core/__tests__/fixtures/queries/pg10.types.graphql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| query { | ||
| allTypes { | ||
| ...typesConnection | ||
| } | ||
| } | ||
|
|
||
| fragment type on Type { | ||
| regrole | ||
| regnamespace | ||
wesselvdv marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| fragment typesConnection on TypesConnection { | ||
| nodes { | ||
| ...type | ||
| } | ||
| edges { | ||
| node { | ||
| ...type | ||
| } | ||
| } | ||
| totalCount | ||
| pageInfo { | ||
| hasNextPage | ||
| hasPreviousPage | ||
| startCursor | ||
| endCursor | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.