feat(graphile-utils): Type update on addPgTableOrderByPlugin #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(omit) take "many" on constraints into account Closes #505. * move `@omit many` constraint condition to "many" relations only and simplify the conditions a bit, outdenting `makeField` by one level Co-authored-by: Benjie Gillam <[email protected]>
Co-authored-by: Benjie Gillam <[email protected]>
BREAKING CHANGE: New minimum Node version is Node v10.18.0
hansololai
changed the title
Contributor
Author
|
Interestingly when I run yarn lint:fix, it also fixed a bunch of README.md file's js syntax. for the purpose of this PR, I did not commit those. |
Member
|
Maybe you have prettier installed globally and it's using that rather than ours? 🤷 |
Member
|
Please could you rebase this on the |
Contributor
Author
|
The rebasing got a lot of conflicts, I didn't want to mess up other stuff so I made another PR from v4 to v4. #629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
makeAddPgTableOrderByPluginprovie a utilility functionorderByAscDesc. The current typescript only allows either astringor aSQLelement to be passed in, but the code actually handles the case (and it is also in the doc) to pass in a function{queryBuilder} => SQL. This PR updates that typescript definition of the function and also the orderbySpec.