feat: bls12_381 that support zkvm-pico #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ArtiomTr this PR is good to review. |
jimmychu0807
commented
Oct 15, 2025
ArtiomTr
requested changes
Oct 30, 2025
.editorconfig
Outdated
| @@ -0,0 +1,24 @@ | |||
| root = true | |||
Collaborator
There was a problem hiding this comment.
I think this is not really necessary, it is better to keep changes as small as possible, as it is just patch for original dependency, not a fork of it
benches/hash_to_curve.rs
Outdated
Comment on lines
22
to
31
| #[cfg(not(feature = "zkvm-pico"))] | ||
| <G1Projective as HashToCurve<ExpandMsgXmd<sha2::Sha256>>>::encode_to_curve( | ||
| [black_box(message)], | ||
| black_box(dst), | ||
| ) | ||
| ); | ||
| #[cfg(feature = "zkvm-pico")] | ||
| <G1Projective as HashToCurve<ExpandMsgXmd<sha2::Sha256>>>::encode_to_curve( | ||
| black_box(message), | ||
| black_box(dst), | ||
| ); |
Collaborator
There was a problem hiding this comment.
So this needs to be unified - single HashToCurve api, not two different versions for different backends
…vm-pico features.
… into zkcrypto/bls12_381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of PR #2 by @Dyslex7c
Check the latest CI test and lint here:
https://github.com/jimmychu0807/grandine-universal-precompiles/actions