-
Notifications
You must be signed in to change notification settings - Fork 67
fix: add api_version breadcrumb to client docs #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @noahdietz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the generated client documentation by embedding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an API version breadcrumb to the generated client documentation, as specified by AIP-4236. The implementation correctly appends the version information to the service description. However, I've identified a couple of areas for improvement to ensure full compliance with the AIP and to handle edge cases gracefully. My feedback includes a suggestion to correctly format the breadcrumb when the API short name is missing, and another to ensure the breadcrumb is always included when an API version is present, regardless of whether a service description exists.
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Show resolved
Hide resolved
.../main/java/com/google/api/generator/gapic/composer/comment/ServiceClientCommentComposer.java
Outdated
Show resolved
Hide resolved
blakeli0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Noah!
You're welcome, thanks for the quick review! |
|
@blakeli0 I assume I can ignore the two failing presubmits? |
Yes, those are fine. FYI, we are in the middle of testing RCs, we'll merge this PR once the testing are done. |
Ok great thanks for letting me know! I do have the power to push the button it seems so I wasn't sure if I should do it myself or not. I will leave it to you! Cheers. |
Adds simple breadcrumb comment to client class commentary including the
google.api.api_versionvalue that this client was generated based on and sends in its requests, as per AIP-4236. This breadcrumb will allow client users to reference the API version used by the client in other API artifacts e.g. product documentation.Fixes internal tracking bug http://b/467138606, child of http://b/467065424.