Skip to content

feat(toolbox-core): Allow specifying protocol in sync client #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twishabansal merged 2 commits into from
Dec 10, 2025
Merged

feat(toolbox-core): Allow specifying protocol in sync client #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb1e03c
feat(toolbox-core): Allow specifying protocol in sync client
twishabansal Dec 10, 2025
abf1dd7
Update sync_client.py
twishabansal Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/toolbox-core/src/toolbox_core/sync_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from deprecated import deprecated

from .client import ToolboxClient
from .protocol import Protocol
from .sync_tool import ToolboxSyncTool


Expand All @@ -40,6 +41,7 @@ def __init__(
client_headers: Optional[
Mapping[str, Union[Callable[[], str], Callable[[], Awaitable[str]], str]]
] = None,
protocol: Protocol = Protocol.MCP,
):
"""
Initializes the ToolboxSyncClient.
Expand All @@ -58,7 +60,7 @@ def __init__(
self.__class__.__loop = loop

async def create_client():
return ToolboxClient(url, client_headers=client_headers)
return ToolboxClient(url, client_headers=client_headers, protocol=protocol)

self.__async_client = run_coroutine_threadsafe(
create_client(), self.__class__.__loop
Expand Down