Unify zstd dependency for basisu
#9493
Open
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z3moon
reviewed
Dec 7, 2025
Contributor
z3moon
left a comment
z3moon
left a comment
There was a problem hiding this comment.
Overall direction looks okay. Do we have any issue/problem due to this? or do we expect benefits like binary size reduction?
| add_subdirectory(${FILAMENT}/shaders) | ||
| add_subdirectory(${EXTERNAL}/abseil/tnt) | ||
| add_subdirectory(${EXTERNAL}/basisu/tnt) | ||
| add_subdirectory(${EXTERNAL}/zstd/tnt) |
Contributor
There was a problem hiding this comment.
I assume you listed zstd first to make the execution doesn't go into the if(NOT TARGET zstd) block in basisu. Could you add some comments about this?
Contributor
Plz ignore my comment as I just saw the other PR's comment #9484 (comment) |
z3moon
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
third_party/zstdshould be the single source ofzstdacross the project. We will only use thezstdunderbasisuwhen the third_party one doesn't exist.