webgpu: manage a pool of staging buffers for updateGPUBuffer #9486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrcloud
force-pushed
the
ry/stagingPool
branch
2 times, most recently
from
603f829 to
24a4fba
Compare
poweifeng
reviewed
Dec 5, 2025
yrcloud
force-pushed
the
ry/stagingPool
branch
from
d6581be to
2284281
Compare
poweifeng
approved these changes
Dec 8, 2025
…es return null, which breaks the code.
…and anymore (the commands have finished executing on GPU)
- use the C++ style MapAsync callback definition
yrcloud
force-pushed
the
ry/stagingPool
branch
from
2284281 to
6564fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGS=450620535
Additionally, in WebGPUQueueManager, create a blank new submission state when a new command encoder is generated instead of in submit()