Skip to content

Conversation

@arnehormann
Copy link
Member

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generate the sample only if we actually run a benchmark. Use a helper function which checks if sample == nil and generates the sample in this case. Or come up with something better ;)

@julienschmidt
Copy link
Member

For now just add the benchmarks to driver_test.go instead of the single file

@arnehormann
Copy link
Member Author

done, PTAL

@julienschmidt
Copy link
Member

LGTM

arnehormann added a commit that referenced this pull request May 14, 2013
add simple benchmarks for speed testing
@arnehormann arnehormann merged commit d32925b into go-sql-driver:master May 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants