Backport - Fix a potential connection pool leak.

[arthurschreiber]

Description

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Documentation was added or is not required

Deployment Notes

[Copilot]

PR Overview

This PR backports a fix for a potential connection pool leak by ensuring that the stack node’s "next" field is cleared when it is popped.

• Adds a test in stack_test.go to verify that the popped node's "next" pointer is nil.
• Updates stack.go so that after a successful pop, the "next" pointer of the popped node is set to nil to prevent connection leaks.

Changes

File	Description
go/pools/smartconnpool/stack_test.go	Adds a test case to verify that the popped node's "next" pointer is nil.
go/pools/smartconnpool/stack.go	Clears the "next" pointer after a successful pop to prevent leaks.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

go/pools/smartconnpool/stack_test.go:13

• Consider adding a separate test case for the scenario where Pop() is called on an empty stack to validate that it correctly handles the edge case without errors.

func TestStackPop(t *testing.T) {

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[github-actions]

This PR was closed because it has been stale for 7 days with no activity.