Escape table name in ReadLastCheckpoint #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a SQL injection vulnerability in the ReadLastCheckpoint function by adding proper escaping to the database and table names in the query, bringing it in line with the security practices already established throughout the codebase.
- Adds
sql.EscapeName()calls for both database name and checkpoint table name - Addresses security concern identified in PR #1595
- Maintains consistency with escaping patterns used in all other SQL queries in the file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thesnowrose
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the query in
ReadLastCheckpointintroduced in #1595 by properly escaping the table name. Thanks to @smartinec for catching this!script/cibuildreturns with no formatting errors, build errors or unit test errors.