Skip to content

Print status to migrationContext logger #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SocalNick wants to merge 2 commits into from
Closed

Print status to migrationContext logger #1193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
654a930
Print status to migrationContext logger
SocalNick Sep 17, 2021
d87d72e
Merge branch 'master' into nc--send-status-to-migration-context-logger
Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions go/logic/migrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ func NewMigrator(context *base.MigrationContext, appVersion string) *Migrator {
return migrator
}

func (this *Migrator) Write(p []byte) (n int, err error) {
s := string(p[:])
this.migrationContext.Log.Infof(s)
return len(s), nil
}

// sleepWhileTrue sleeps indefinitely until the given function returns 'false'
// (or fails with error)
func (this *Migrator) sleepWhileTrue(operation func() (bool, error)) error {
Expand Down Expand Up @@ -408,7 +414,7 @@ func (this *Migrator) Migrate() (err error) {
if err := this.hooksExecutor.onRowCopyComplete(); err != nil {
return err
}
this.printStatus(ForcePrintStatusRule)
this.printStatus(ForcePrintStatusRule, this)

if this.migrationContext.IsCountingTableRows() {
this.migrationContext.Log.Info("stopping query for exact row count, because that can accidentally lock out the cut over")
Expand Down Expand Up @@ -588,7 +594,7 @@ func (this *Migrator) waitForEventsUpToLock() (err error) {
waitForEventsUpToLockDuration := time.Since(waitForEventsUpToLockStartTime)

this.migrationContext.Log.Infof("Done waiting for events up to lock; duration=%+v", waitForEventsUpToLockDuration)
this.printStatus(ForcePrintStatusAndHintRule)
this.printStatus(ForcePrintStatusAndHintRule, this)

return nil
}
Expand Down Expand Up @@ -720,7 +726,7 @@ func (this *Migrator) atomicCutOver() (err error) {
// initiateServer begins listening on unix socket/tcp for incoming interactive commands
func (this *Migrator) initiateServer() (err error) {
var f printStatusFunc = func(rule PrintStatusRule, writer io.Writer) {
this.printStatus(rule, writer)
this.printStatus(rule, writer, this)
}
this.server = NewServer(this.migrationContext, this.hooksExecutor, f)
if err := this.server.BindSocketFile(); err != nil {
Expand Down Expand Up @@ -799,14 +805,14 @@ func (this *Migrator) initiateInspector() (err error) {

// initiateStatus sets and activates the printStatus() ticker
func (this *Migrator) initiateStatus() {
this.printStatus(ForcePrintStatusAndHintRule)
this.printStatus(ForcePrintStatusAndHintRule, this)
ticker := time.NewTicker(time.Second)
defer ticker.Stop()
for range ticker.C {
if atomic.LoadInt64(&this.finishedMigrating) > 0 {
return
}
go this.printStatus(HeuristicPrintStatusRule)
go this.printStatus(HeuristicPrintStatusRule, this)
}
}

Expand Down