Skip to content

Conversation

@brianaj
Copy link
Collaborator

@brianaj brianaj commented Dec 3, 2025

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Combines #1450 and #1414

Copilot AI review requested due to automatic review settings December 3, 2025 20:33
Copilot finished reviewing on behalf of brianaj December 3, 2025 20:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades GitHub Actions versions across the CI/CD workflow files. The changes update actions/checkout from v4 to v5, actions/setup-dotnet from v4 to v5, and stefanzweifel/git-auto-commit-action from v5 to v7. Additionally, it refines conditional logic in the CI workflow to properly scope test coverage and result uploads to only the C# build matrix entries, and removes persist-credentials: false from the publish job's checkout step to enable automated commits using a custom token.

  • Updated core GitHub Actions (actions/checkout, actions/setup-dotnet) to their latest major versions
  • Added matrix.language == 'csharp' condition to test coverage and upload steps to avoid redundant operations for non-C# matrix entries
  • Removed persist-credentials: false in the publish job to allow git-auto-commit-action to function correctly

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/integration-tests.yml Updated actions/checkout from v4 to v5 in two locations
.github/workflows/copilot-setup-steps.yml Updated actions/checkout from v4 to v5
.github/workflows/CI.yml Updated actions/checkout (v4→v5), actions/setup-dotnet (v4→v5), git-auto-commit-action (v5→v7); added matrix.language == 'csharp' conditions to test-related steps; removed persist-credentials: false from publish job checkout

- uses: actions/checkout@v5

- name: Setup .NET
uses: actions/setup-dotnet@v2
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent action version: actions/setup-dotnet@v2 should be updated to @v5 to match the upgrades in CI.yml (lines 38, 111, 158, 306). This ensures consistency across all workflow files and provides the latest features and fixes.

Suggested change
uses: actions/setup-dotnet@v2
uses: actions/setup-dotnet@v5

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update in separate dependabot #1175

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Unit Test Results

  1 files    1 suites   10m 24s ⏱️
960 tests 960 ✅ 0 💤 0 ❌
961 runs  961 ✅ 0 💤 0 ❌

Results for commit 7070eff.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@xiaonile xiaonile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
ado2gh 72% 70% 712
Octoshift 83% 72% 1737
bbs2gh 83% 78% 663
gei 81% 72% 574
Summary 81% (7734 / 9600) 73% (1837 / 2519) 3686

@brianaj brianaj changed the title Brianaj/external pr 1450 Bump actions/checkout from 4 to 5 Dec 4, 2025
@brianaj brianaj merged commit c6cbbc5 into main Dec 4, 2025
35 checks passed
@brianaj brianaj deleted the brianaj/external-pr-1450 branch December 4, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants