Add missing typings for useWebWorkers and useCompressionStream to ZipWriterConstructorOptions
#616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Indeed, I guess I must have forgotten to extend the interface. Thank you very much for your contribution, it will be available in the next version. |
Contributor
Author
|
You're most welcome! Happy to be of service ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found that ZipWriter options is currently missing typings for
useWebWorkersanduseCompressionStreamwhich are supported by the runtime code.Making ZipWriterConstructorOptions extend WorkerConfiguration seems to be the best way of implementing this.