add option to prevent wrapping also the functions arguments #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you give me an example where this fails so I can figure out a better way to potentially do it automatically? |
mattrobenolt
added a commit
that referenced
this pull request
Jan 19, 2014
add option to prevent wrapping also the functions arguments
Contributor
Author
|
Sure. Checkout http://jsfiddle.net/k7uaT/ You can add/remove raven to see the problem. |
Contributor
|
Ohh, I see. JavaScript sucks. :( Thanks for the PR. |
kamilogorek
pushed a commit
that referenced
this pull request
Jun 12, 2018
kamilogorek
pushed a commit
that referenced
this pull request
Jun 12, 2018
mydea
added a commit
that referenced
this pull request
May 12, 2025
See https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1 ### Bug Fixes * handling of circular dependencies ([#181](nodejs/import-in-the-middle#181)) ([b58092e](nodejs/import-in-the-middle@b58092e)) * importing JSON files ([#182](nodejs/import-in-the-middle#182)) ([8c52014](nodejs/import-in-the-middle@8c52014)) * warning from use of context.importAssertions ([#179](nodejs/import-in-the-middle#179)) ([8e56cf1](nodejs/import-in-the-middle@8e56cf1))
mydea
added a commit
that referenced
this pull request
May 12, 2025
See https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1 ### Bug Fixes * handling of circular dependencies ([#181](nodejs/import-in-the-middle#181)) ([b58092e](nodejs/import-in-the-middle@b58092e)) * importing JSON files ([#182](nodejs/import-in-the-middle#182)) ([8c52014](nodejs/import-in-the-middle@8c52014)) * warning from use of context.importAssertions ([#179](nodejs/import-in-the-middle#179)) ([8e56cf1](nodejs/import-in-the-middle@8e56cf1)) This version is already allowed by our range, but in order to ensure everybody gets this, bumping it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I've been running into some problems when wrapping require JS define and require functions. I often return functions that have to be called as constructor functions. My first approach was checking if the function is called as a constructor function and if so calling the wrapped function with the new keyword as well. Which is impossible as long as you want variable arguments.
The next approach was using a ES6 Object.setPrototypeOf() polyfill. It's working but it is strongly discouraged, because it is very slow and unavoidably slows down subsequent execution in modern JavaScript implementations.
So I ended up adding a option to prevent wrapping the functions arguments.
~ Tobi