-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add option to disable logging messages as breadcrumbs #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The Native SDK's Qt integration does something similar and forwards all Qt logging output to Sentry as breadcrumbs. Personally, I find it quite noisy and annoying, which makes me wonder if the feature would be better off as opt-in... How do other SDKs handle this? 🤔 |
|
@jpnurmi I think this is going to change with the upcoming Sentry Logs and logger changes. That should give us a possibility to configure these things in much more detail. |
|
This only affects projects that add a lot of |
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Document logger_messages_as_breadcrumbs option, according to changes in: - getsentry/sentry-godot#305 and also some other options that we're missing in the docs. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [x] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
This PR adds option
logger/messages_as_breadcrumbswhich is enabled by default. This allows disabling messages as breadcrumbs by a simple toggle. Since some projectsprint()heavily into console, this option should be quite useful.