Skip to content

fix: Fix crashing when SDK is disabled via options #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruno-garcia merged 2 commits into from
Jul 17, 2025
Merged

fix: Fix crashing when SDK is disabled via options #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d66b9
Fix null pointer dereference in SentrySDK::get_user
limbonaut Jul 16, 2025
9408e76
Update CHANGELOG.md
limbonaut Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- Check options.enabled during SDK initialization ([#250](https://github.com/getsentry/sentry-godot/pull/250))
- Fix crashing when SDK is disabled via options ([#253](https://github.com/getsentry/sentry-godot/pull/253))

## 1.0.0-alpha.0

Expand Down
2 changes: 1 addition & 1 deletion src/sentry_sdk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ void SentrySDK::set_user(const Ref<SentryUser> &p_user) {

Ref<SentryUser> SentrySDK::get_user() const {
MutexLock lock(*user_mutex.ptr());
return user->duplicate();
return user.is_valid() ? user->duplicate() : nullptr;
}

void SentrySDK::remove_user() {
Expand Down
Loading