feat: don't show an error if opening a closed buffon window #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescarpi
force-pushed
the
feat/startify
branch
6 times, most recently
from
a8a9bc4 to
4117c9a
Compare
It also adds more control when an event from an external plugin closes the buffon window. This commit was motivated by the fact that when the buffon and startify plugins were combined, buffon crashed.
francescarpi
force-pushed
the
feat/startify
branch
from
4117c9a to
76e1c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is to fix issue #78.
For unknown reasons, after installing the Startify plugin, the
buffonwindow cannot be opened. Neovim assigns an invalid window ID to thebuffon.The first thing I did was to avoid opening invalid windows and suppress the annoying Vim error.
I'm still working on figuring out how to apply the final fix.