Factorize breakpoints map handling #9439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factorize breakpoint map handling in `grid-column-gutter` and `grid-column-margin` mixins. Changes: - Add the `-zf-breakpoint-value` mixin which generate its content with the value `$-zf-bp-value` depending on its parameter, like `grid-column-gutter` and `grid-column-margin` did (see the `@mixin -zf-breakpoint-value` doc) - Use the `-zf-breakpoint-value` mixin in `grid-column-gutter` and `grid-column-margin` and remove duplicated code. - Rename the `grid-column-gutter` function to `-zf-breakpoint-value` and move it to `/scss/util/_breakpoint.scss`. This function had a generic behaviour.
- Allow the `-zf-get-bp-val` function to take a single value as responsive config `$map` and return it regardless of `$value`. - Remove useless function `-zf-breakpoint-value`
Contributor
Author
|
@andycochran What do you think ? |
Contributor
|
Nice. I think this works, so long as we're okay with breaking any apps that currently make use of the |
Contributor
Author
|
@andycochran (poke @kball) |
Contributor
|
Oh, it's a new function? Nix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9425 - Factorize the handling of breakpoints map in
grid-column-gutterandgrid-column-marginmixins.Changes:
@mixin -zf-breakpoint-valuewhich generate its content with the value$-zf-bp-valuedepending on its parameter, like@mixin grid-column-gutterand@mixin grid-column-margindid (see the@mixin -zf-breakpoint-valuedoc)@mixin -zf-breakpoint-valuein@mixin grid-column-gutterand@mixin grid-column-marginand remove duplicated code.@function -zf-get-bp-valto take a single value as responsive config$mapand return it regardless of$value.@function grid-column-gutter