Contain nested rows to grid

[gpspake]

This commit removes a single line that was recently added that results in the following style:

.row .row {
  max-width: none
}

The line was added in response to #8304. However, the appropriate solution would have been to add the expanded class to nested rows. Setting max-width to none introduces a break. If a nested row needs to be full width, the expanded class can be applied to that row; however, if nested row max-width is set to none, there's no way to contain a row to the grid inside of an expanded row.

If a row is nested inside of an expanded row, it should be contained to the grid unless the expanded class is explicitly added to the nested row.

This fixes #8886

[gpspake]

For further reference, here's how this has worked up until 6.2.1. The expanded class already sets max-width:none so applying it to all nested rows is too broad.

<div class="row expanded"> <!--Parent - Full width-->

    <div class="row"> <!--Nested - Contained to grid-->

    </div>

    <div class="row expanded"> <!--Nested - Full width-->

    </div>

</div>

[andycochran]

👍 I agree; this commit was a mistake.

[andycochran]

@gakimball, are you okay with reverting this and requiring .expanded to fix nested rows? Other ideas?

[rafibomb]

I'll take this one! I'll test it and see if it's the way to go.

[jrock17]

@rafibomb I think there is a related issue on the flex-grid. It's missing the margin-left and margin-right for nested rows inside an expanded row.

In _flex-grid.scss around line 165 I think you need to add the margin stuff for the nested row:

    // Expanded row
    &.expanded {
      max-width: none;

        .row {
            margin-left: auto;
            margin-right: auto;
        }
    }

[gpspake]

Small little anecdote that doesn't really change anything here...
We added a temporary fix for this which explicitly adds a max-width back to .row .row
which we just realized overrides the nested expanded rules and prevents us from using nested expanded rows (since they're contained to the grid - even with the expanded class) :(
If we get rid of our temporary max-width rule, though, we're back to square one.
best bet is to undo that pesky one-liner