Make it work on newer mkdocstrings, fix deprecation warnings #4626
+252
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaut
requested changes
Dec 8, 2025
| from pathlib import Path | ||
| from subprocess import PIPE, STDOUT, CalledProcessError, Popen | ||
| from typing import Any, List, Mapping, Optional | ||
| from typing import Any, ClassVar, TYPE_CHECKING, final, override |
Contributor
There was a problem hiding this comment.
CI complains about override:
ImportError: cannot import name 'override' from 'typing' (/usr/lib/python3.10/typing.py)
https://github.com/fmtlib/fmt/actions/runs/20028626137/job/57455771194
mochaaP
force-pushed
the
mochaa-fix-mkdocstrings
branch
3 times, most recently
from
da3eef6 to
0cf82a5
Compare
Contributor
Author
vitaut
reviewed
Dec 8, 2025
| sudo apt update | ||
| sudo apt install doxygen | ||
| pip install mkdocs-material==9.5.25 mkdocstrings==0.26.1 mike==2.1.1 | ||
| pip install mkdocs-material==9.7.0 mkdocstrings==1.0.0 mike==2.1.3 typing_extensions==4.15.0 |
Contributor
There was a problem hiding this comment.
Are typing_extension required? In general it's good to keep the number of deps small.
Contributor
Author
There was a problem hiding this comment.
this is the backported runtime behavior for builtin typing. it's maintained by the python team and only has one file so i'm okay with it.
mochaaP
force-pushed
the
mochaa-fix-mkdocstrings
branch
from
0cf82a5 to
fdad8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on mkdocs 1.6.1 + mkdocstrings 1.0.0 + Python 3.14.0.
Ruff check target = py3.8