Skip to content

Conversation

@4storia
Copy link
Contributor

@4storia 4storia commented Dec 22, 2020

For the recently filed issue: #131

Creating dictionary without prototype to avoid prototype collisions from packed strings that contain javascript

Creating dictionary without prototype to avoid prototype collisions from packed string
@coveralls
Copy link

coveralls commented Dec 22, 2020

Pull Request Test Coverage Report for Build 538

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.383%

Totals Coverage Status
Change from base Build 537: 0.0%
Covered Lines: 130
Relevant Lines: 138

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #132 (02bba08) into master (1b64bdd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files           1        1           
  Lines         138      138           
=======================================
  Hits          130      130           
  Misses          8        8           
Impacted Files Coverage Δ
lzwCompress.js 94.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b64bdd...02bba08. Read the comment docs.

Copy link
Owner

@floydpink floydpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@floydpink floydpink merged commit f59de14 into floydpink:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants