Skip to content

fix(fcm): Increase batch send timeout to 15 seconds #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahirumaramba merged 2 commits into from
Dec 13, 2022
Merged

fix(fcm): Increase batch send timeout to 15 seconds #1999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
149d7f1
fix(fcm): Increase batch send timeout to 15 seconds
lahirumaramba Dec 2, 2022
cc54da2
Merge branch 'master' into lm-fix-batch-timeout
lahirumaramba Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/messaging/batch-request-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
import { FirebaseAppError, AppErrorCodes } from '../utils/error';

const PART_BOUNDARY = '__END_OF_PART__';
const TEN_SECONDS_IN_MILLIS = 10000;
const TEN_SECONDS_IN_MILLIS = 15000;

/**
* Represents a request that can be sent as part of an HTTP batch request.
Expand Down
2 changes: 1 addition & 1 deletion test/unit/messaging/batch-requests.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ describe('BatchRequestClient', () => {
expect(args.url).to.equal(batchUrl);
expect(args.headers).to.have.property(
'Content-Type', 'multipart/mixed; boundary=__END_OF_PART__');
expect(args.timeout).to.equal(10000);
expect(args.timeout).to.equal(15000);
const parsedRequest = parseHttpRequest(args.data as Buffer);
expect(parsedRequest.multipart.length).to.equal(requests.length);

Expand Down