Replace incorrect std::forward usage #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of these looks like they were meant tobe a move.
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
I've got an unmerged clang-tidy check in my local build that finds places where |
ispeters
approved these changes
Jul 4, 2023
| public: | ||
| explicit type(Operation& op, Receiver&& r) : | ||
| op_(op), receiver_{std::forward<Receiver>(r)} | ||
| op_(op), receiver_{std::move(r)} |
Contributor
There was a problem hiding this comment.
This is better than it was, but this whole file looks like it needs to have the value categories of the various forwarded arguments reconsidered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these looks like they were meant tobe a move.