Update manual about the default value of -T#/--threads=#
#4474
Conversation
The section about `ZSTD_NBTHREADS` already explains the default number of threads, since it changed from 1 (commit 17beeb5). But the option description for `-T#`/`--threads=#` incorrectly said the default was still 1. I noticed this when I found compression slower with `-T1` than without it.
|
Hi @jlokier! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thanks @jlokier , that's indeed a good point ! |
2 participants
The section about
ZSTD_NBTHREADSalready explains the default number of threads, since it changed from 1 (commit 17beeb5). But the option description for-T#/--threads=#incorrectly said the default was still 1.I noticed this when I found compression slower with
-T1than without it.