-
Notifications
You must be signed in to change notification settings - Fork 3.5k
WasmFS: Add nanosecond support to WasmFS #19629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WasmFS: Add nanosecond support to WasmFS #19629
Conversation
…9/emscripten into library-wasmfs-utime
|
It looks like the diff still contains changes from #19561. If you change the target branch for this PR from |
|
Ah I see. For this PR, I did |
|
One way would be to add a commit undoing the changes on the original PR, then fork a new branch off of it, then revert the undoing of the changes on the new branch so that the revert commit actually reapplies the changes. Then even if the diff for the PR that adds the changes includes everything, we can just look at the diff for that revert commit to see only the new changes. |
system/lib/wasmfs/syscalls.cpp
Outdated
| return err; | ||
| } | ||
|
|
||
| // TODO: Set tv_nsec (nanoseconds) as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this TODO can be removed now
kripken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm but we have some failures on main it seems, that are showing up here and everywhere else. Work is ongoing to fix those but this will need to wait to land on that.
|
Rebasing or merging should fix the CI issues. |
This PR adds nanosecond support for file times in WasmFS, specifically when used for
utimeandstat. This PR was separated from #19561 (comment), reusing the same tests.