allow to set duration higher than width of shell size #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edouard-lopez
requested changes
Feb 1, 2019
Owner
edouard-lopez
left a comment
edouard-lopez
left a comment
There was a problem hiding this comment.
I did a review, but I got a new line for each step with your code.
Also, you need to rebase on master as I added some tests
Contributor
Author
|
I made some changes and its working fine, no new line, but still its unable to erase the entire last line when completed 100%. |
edouard-lopez
requested changes
Feb 1, 2019
Owner
edouard-lopez
left a comment
edouard-lopez
left a comment
There was a problem hiding this comment.
That look nice!
Could you update based on my review, I will merge next week as I won't be available in the coming days.
Contributor
Author
|
I did a quick review and have updated the file. Thanks for the help and support. I would appreciate any advice or suggestions for the future. |
edouard-lopez
approved these changes
Feb 5, 2019
Bug fix : can't set duration higher than width of shell size
Fixed bug: updated patch
edouard-lopez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #6
I was not able to set the duration higher than the shell size, so I introduced a new variable factor and now the bar fills accordingly( bar fills from done=0;done <(elapsed/factor)).