Skip to content

Conversation

@laurentcodes
Copy link
Contributor

added a new city to lagos, nigeria
i want to know if i added this correctly before i proceed to add more, thanks.

@laurentcodes laurentcodes marked this pull request as draft February 22, 2024 13:39
@laurentcodes laurentcodes marked this pull request as ready for review February 22, 2024 13:39
@dr5hn
Copy link
Owner

dr5hn commented Feb 23, 2024

@laurentcodes Thanks for the PR!

Can you please move your entry to very end of the world.sql and make sure to assign a ID (last_id + 1) to that newly added row?

@laurentcodes
Copy link
Contributor Author

@dr5hn sure! will do that.

@laurentcodes
Copy link
Contributor Author

@dr5hn, i have moved the entry to the end of the world.sql file and set an id (23), please check if correct

@dr5hn
Copy link
Owner

dr5hn commented Feb 26, 2024

@laurentcodes You have moved to subregions table, can you please move it to cities table?

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 26, 2024
@laurentcodes
Copy link
Contributor Author

@dr5hn i just did, please recheck, last entry under cities if that's correct

@dr5hn
Copy link
Owner

dr5hn commented Feb 26, 2024

@laurentcodes You need to fix semi colon and comma at End of line of last and 2nd last row

@laurentcodes
Copy link
Contributor Author

@dr5hn fixed

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 26, 2024
@dr5hn dr5hn merged commit 7d38fc4 into dr5hn:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants