Skip to content

Conversation

@porridge
Copy link

@porridge porridge commented Dec 1, 2025

This bit would have let me avoid having to file #567

Fixes: #567

Just a bit more verbosity that would have made it clear for me.

Signed-off-by: Marcin Owsiany <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
porridge and others added 3 commits December 8, 2025 08:39
Co-authored-by: Brennan Kinney <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
Signed-off-by: Marcin Owsiany <[email protected]>
@porridge
Copy link
Author

porridge commented Dec 8, 2025

PTAL @polarathene

Copy link

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


I'm not sure if swapping the true|false value list to false|true will be inferred that way, conventionally you'd refer to booleans as true false, so it just reads a bit weird the other way around 😅

The latest setting would now also differ in the value list arrangement, although it does have auto as the first value which just happens to be it's default too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flavor's suffix not applied to latest

2 participants