Skip to content

Conversation

@dfed
Copy link
Owner

@dfed dfed commented Dec 10, 2025

Per #70, turning on .treatAllWarnings(as: .error) in a library causes errors for library consumers since Swift Package Manager suppresses warnings in package dependencies.

We're still enforcing warnings as errors in CI, so we aren't going to introduce warnings into the repo. Unfortunate design decision within SPM, but here we are.

@dfed dfed self-assigned this Dec 10, 2025
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b30374b) to head (2da42c0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1301      1301           
=========================================
  Hits          1301      1301           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfed dfed marked this pull request as ready for review December 10, 2025 20:57
@dfed dfed merged commit 721e823 into main Dec 10, 2025
20 of 21 checks passed
@dfed dfed deleted the dfed--warnings-enabled-sadly branch December 10, 2025 20:58
@dfed dfed linked an issue Dec 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error when adding to project

2 participants