chore: remove api/v2 replace directive #4392
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR gets rid of the replace directive in the
go.modfor thefd.axjsq.dpdns.org/dexidp/dexmodule.Doing so has the benefit of making it possible to
go install github.com/dexidp/dex/cmd/dex, which at least slightly addresses the underlying need from #827, though an officially provided binary release would of course be better.What this PR does / why we need it
This change addresses the error message you'll receive if you try to
go install github.com/dexidp/dex/cmd/dex:It also bumps the
github.com/dexidp/dex/api/v2dependency tov2.4.0since parts of the code rely on types introduced in thefd.axjsq.dpdns.org/dexidp/dex/api/v2releasev2.4.0.This has been previously brought up in a discussion.
Special notes for your reviewer