Skip to content

fix: logs issue for init containers #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gireesh-naidu merged 12 commits into from
Mar 7, 2023
Merged

fix: logs issue for init containers #3076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a69e6f9
container name validation across all kinds of containers
gireesh-naidu Mar 3, 2023
07fc02c
missing nil ptr check added with error logging
gireesh-naidu Mar 3, 2023
5b7de8e
ephemeral containers added in pod metadata
gireesh-naidu Mar 3, 2023
bde0a4b
proto file generated
adi6859 Mar 4, 2023
e18debb
code review changes
gireesh-naidu Mar 6, 2023
b8570b9
proto file generated
adi6859 Mar 6, 2023
c230e33
sending error in stream itself
gireesh-naidu Mar 6, 2023
190db78
sending error in stream itself
gireesh-naidu Mar 6, 2023
3d30520
added event id as timestamp for the custom error message
gireesh-naidu Mar 7, 2023
091d418
fix
gireesh-naidu Mar 7, 2023
b0b6077
merge main
gireesh-naidu Mar 7, 2023
ffe73c1
proto generated
adi6859 Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions api/connector/Connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,21 @@ func (impl PumpImpl) StartK8sStreamWithHeartBeat(w http.ResponseWriter, isReconn
if !ok {
http.Error(w, "unexpected server doesnt support streaming", http.StatusInternalServerError)
}
if err != nil {
http.Error(w, errors.Details(err), http.StatusInternalServerError)
}

w.Header().Set("Transfer-Encoding", "chunked")
w.Header().Set("Content-Type", "text/event-stream")
w.Header().Set("X-Accel-Buffering", "no")
w.Header().Set("X-Content-Type-Options", "nosniff")
w.Header().Set("Cache-Control", "no-cache, no-transform")

if err != nil {
err := impl.sendEvent(nil, []byte("CUSTOM_ERR_STREAM"), []byte(err.Error()), w)
if err != nil {
impl.logger.Errorw("error in writing data over sse", "err", err)
}
return
}

if isReconnect {
err := impl.sendEvent(nil, []byte("RECONNECT_STREAM"), []byte("RECONNECT_STREAM"), w)
if err != nil {
Expand Down
Loading