Skip to content

Conversation

@Elessar1802
Copy link
Contributor

@Elessar1802 Elessar1802 commented Dec 2, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2718

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

vivek-devtron
vivek-devtron previously approved these changes Dec 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @devtron-labs/devtron-fe-common-lib dependency and adds ArgoCD token-based authentication for development/testing purposes.

Key Changes:

  • Downgrades common-lib from version 1.21.0-pre-1 to 1.20.6-alpha-88
  • Introduces environment variable-based ArgoCD token authentication in the login flow

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Updates common-lib dependency version from 1.21.0-pre-1 to 1.20.6-alpha-88
yarn.lock Updates lockfile to reflect the new common-lib version and its dependency checksums
src/components/login/Login.tsx Adds conditional authentication logic using VITE_ARGOCD_TOKEN environment variable to bypass SSO login

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Elessar1802 Elessar1802 merged commit 7cbf596 into kubecon-2025 Dec 3, 2025
12 checks passed
@Elessar1802 Elessar1802 deleted the fix/data-table branch December 3, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants